blob: f3dc117856d7e6ceb9b39cb907c80d7274fdef80 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
|
virtual: 0.931
semantic: 0.781
hypervisor: 0.773
PID: 0.715
device: 0.713
performance: 0.579
graphic: 0.560
ppc: 0.557
mistranslation: 0.500
user-level: 0.457
vnc: 0.455
kernel: 0.443
register: 0.399
network: 0.367
peripherals: 0.365
x86: 0.346
arm: 0.317
architecture: 0.310
risc-v: 0.307
debug: 0.304
i386: 0.280
boot: 0.273
TCG: 0.272
permissions: 0.243
VMM: 0.206
files: 0.179
socket: 0.147
assembly: 0.136
KVM: 0.054
block_set_io_throttle complaints Need exactly one of 'device' and 'id'
All of sudden, after a qemu update, block_set_io_throttle does not work anymore.
Full command to QEMU monitor --
(qemu) block_set_io_throttle db 0 0 0 0 0 0
Need exactly one of 'device' and 'id'
The help text still point to the same old syntax, which no longer works.
On 03/30/2017 02:14 AM, dE wrote:
> Public bug reported:
>
> All of sudden, after a qemu update, block_set_io_throttle does not work
> anymore.
>
> Full command to QEMU monitor --
>
> (qemu) block_set_io_throttle db 0 0 0 0 0 0
> Need exactly one of 'device' and 'id'
>
> The help text still point to the same old syntax, which no longer works.
Broken in 2.8, fixed here (will be in 2.9):
commit 3f35c3b166c18043596768448e5d91b5d52f8353
Author: Eric Blake <email address hidden>
Date: Fri Jan 20 17:03:59 2017 -0600
hmp: fix block_set_io_throttle
Commit 7a9877a made the 'device' parameter to BlockIOThrottle
optional, favoring 'id' instead. But it forgot to update the
HMP usage to set has_device, which makes all attempts to change
throttling via HMP fail with "Need exactly one of 'device' and 'id'"
CC: <email address hidden>
Signed-off-by: Eric Blake <email address hidden>
Message-Id: <email address hidden>
Reviewed-by: Stefan Hajnoczi <email address hidden>
Signed-off-by: Dr. David Alan Gilbert <email address hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
|