summary refs log tree commit diff stats
path: root/results/scraper/launchpad/1402802
blob: 95bbd1e63811c8a6cc6601c5a03ec380c72b8941 (plain) (blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
target-tricore/translate.c:3812: possible bad expression ?


From a run of cppcheck, a static analysis checker, over the
source code of qemu trunk, dated 20141215, is the new error:

[qemu/target-tricore/translate.c:3812]: (style) Expression '(X & 0x3f) == 0x6f' is always false.

Source code is

    if (unlikely((op1 & 0x3f) == OPCM_32_BRN_JTT)) {

Suggest code rework.

Absolutly correct. The mask should be 0x7f. I will fix that asap.

http://git.qemu.org/?p=qemu.git;a=commitdiff;h=7f13420ec000ad7644b65e