blob: a371703c2fbd0378ce93dbb6b4366943c6d9b6f6 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
|
disas/libvixl/vixl/invalset.h: possible dodgy code in binary search ?
[qemu/disas/libvixl/vixl/invalset.h:442]: (style) Array index 'low' is used before limits check.
Source code is
while (!IsValid(elements[low]) && (low < high)) ++low;
Also:
qemu/disas/libvixl/vixl/invalset.h:450]: (style) Array index 'middle' is used before limits check.
The source code is
while (!IsValid(elements[high]) && (low < high)) --high;
Mind you, these lines of code look similar but didn't get reported:
while (!IsValid(elements[middle]) && (middle < high - 1)) ++middle;
while (!IsValid(elements[middle]) && (low + 1 < middle)) --middle;
Given that binary search is notoriously tricky to get correct and a standard C library routine
I am puzzled as to why the standard library routine didn't get used, with of course a custom
comparison function.
That doesn't look like a bounds check to me, so I think your checker is producing false positives.
libvixl is third-party code in any case, so stylistic questions are better directed to them upstream. But I think the difference between this code and a standard binary search is (as the comment says) that it ignores invalid elements in the array.
|