blob: 6083aab6de18c9273e20bbee1132d5d6bc7716d3 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
|
qemu/target/arm/translate-a64.c:2039: bad test ?
qemu/target/arm/translate-a64.c:2039]: (warning) Logical disjunction always evaluates to true: op3 != 2 || op3 != 3.
Source code is
if (op3 != 2 || op3 != 3) {
Maybe better code
if (op3 != 2 && op3 != 3) {
Maybe using gcc flag -Wlogical-op might help find bugs like this in future.
There is a patch on list for this:
https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg06728.html
Using the flag is a good idea.
The patch is now in master.
|