blob: 1894f21e350808eb26b0292c2d11c166c31fc251 (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
|
mistranslation: 0.867
device: 0.680
instruction: 0.673
graphic: 0.582
semantic: 0.454
network: 0.417
socket: 0.325
vnc: 0.296
boot: 0.104
other: 0.079
KVM: 0.073
assembly: 0.050
SDL2 UI sends a NULL to sdl_grab_start if fullscreen, which crashes
in ui/sdl2.c:
if (full_screen) {
gui_fullscreen = 1;
sdl_grab_start(0);
}
Is sent, but no null checks are made in sdl_grab_start (its assumed to be an allocated pointer). So a crash happens if you start qemu -full-screen.
It should at lease send the first [0] of the newly allocated sdl2_console through.
Quickly looking around should look something like:
if (full_screen) {
gui_fullscreen = 1;
sdl_grab_start(&sdl2_console[0]);
}
The NULL pointer check has been added here:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=f2335791fd0ceb2f9e3
|